Page MenuHomePhabricator

Optimize feed story gc query.
AbandonedPublic

Authored by Pawka on Sep 10 2015, 11:34 AM.
Tags
None
Referenced Files
F13218468: D14091.id34058.diff
Sat, May 18, 12:37 PM
F13218463: D14091.diff
Sat, May 18, 12:37 PM
F13218134: D14091.id.diff
Sat, May 18, 10:23 AM
F13212764: D14091.diff
Fri, May 17, 7:02 AM
F13197494: D14091.diff
Mon, May 13, 12:13 AM
F13179956: D14091.diff
Wed, May 8, 9:33 PM
Unknown Object (File)
Sat, May 4, 7:27 PM
Unknown Object (File)
Wed, May 1, 1:03 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Ref: T9382. Removed ORDER BY clause to make query perform faster.

Test Plan

Launch phd workers and check if older than 90 days feed stories are
removed.

Diff Detail

Event Timeline

Pawka retitled this revision from to Optimize feed story gc query..
Pawka updated this object.
Pawka edited the test plan for this revision. (Show Details)
Pawka added a reviewer: epriestley.

See T9382#136333. I'd like to understand this behavior better before making this change.

Notably, this makes the query plan worse on our dataset, although we already GC'd so we don't have a large dataset handy to test if it makes the actual query worse or not.

Let's ignore DIFF this then. Probably this is some configuration issue what we do not see now ;)