Page MenuHomePhabricator
Differential D14075

Improve temporary file upload API and add viewPolicy support
ClosedPublic
Actions

Authored by epriestley on Sep 7 2015, 3:29 PM.
Tags
None
Referenced Files
F19136673: D14075.id34020.diff
Dec 10 2025, 9:26 AM
F19135925: D14075.id34020.diff
Dec 10 2025, 9:13 AM
F19105648: D14075.id.diff
Dec 6 2025, 9:41 AM
F19069276: D14075.id.diff
Nov 30 2025, 1:30 PM
F19058765: D14075.diff
Nov 29 2025, 3:21 AM
F19056176: D14075.id.diff
Nov 28 2025, 7:10 PM
F19035088: D14075.diff
Nov 25 2025, 3:59 PM
F19034952: D14075.diff
Nov 25 2025, 3:42 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7148: Allow users to export their data from Phacility
Commits
rARC55d9cc701316: Improve temporary file upload API and add viewPolicy support
Summary

Ref T7148. In D14056, I let arc upload upload temporary files, but this is a better way to do some of the internals. Also add support for setting a viewPolicy.

Test Plan

Used arc upload, arc upload --temporary.

Diff Detail

Repository
rARC Arcanist
Branch
upapi1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7932
Build 8893: [Placeholder Plan] Wait for 30 Seconds
Build 8892: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34017.Sep 7 2015, 3:29 PM
epriestley retitled this revision from to Improve temporary file upload API and add viewPolicy support.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7148: Allow users to export their data from Phacility.
chad accepted this revision.Sep 7 2015, 4:04 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2015, 4:04 PM
Closed by commit rARC55d9cc701316: Improve temporary file upload API and add viewPolicy support (authored by epriestley, committed by epriestley). · Explain WhySep 7 2015, 7:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
upload/
44 lines
37 lines
workflow/
9 lines

Diff 34017

View Options

src/upload/ArcanistFileDataRef.php

Loading...
View Options

src/upload/ArcanistFileUploader.php

Loading...
View Options

src/workflow/ArcanistUploadWorkflow.php

Loading...
Phabricator · Built by Phacility