Update Owners docs a bit
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 10:51 PM.

Details

Reviewers

Maniphest Tasks

T8320: Bring Owners out of the dark ages
T8661: Unclear distinction between Herald rule and Owners package
T9218: Should Owners allow multiple packages to own the same file?

Commits

Restricted Diffusion Commit
rPce7c2097b216: Update Owners docs a bit

Summary

Fixes T9218. Fixes T8320. Fixes T8661. This isn't exhaustive but documents the stuff that cropped up in this iteration as needing documentation. In particular:

Be explicit about multiple ownership.
Explain value of having one place to update your giant regexp of a trillion paths.

Test Plan

Read documentation.

Diff Detail

Repository

rP Phabricator

Branch

ownersdoc

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7865
Build 8761: [Placeholder Plan] Wait for 30 Seconds
Build 8760: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33908.Aug 31 2015, 10:51 PM

epriestley retitled this revision from to Update Owners docs a bit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9218: Should Owners allow multiple packages to own the same file?, T8661: Unclear distinction between Herald rule and Owners package, T8320: Bring Owners out of the dark ages.

chad accepted this revision.Aug 31 2015, 10:58 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 10:58 PM

epriestley mentioned this in T8320: Bring Owners out of the dark ages.Aug 31 2015, 10:59 PM

Closed by commit rPce7c2097b216: Update Owners docs a bit (authored by epriestley, committed by epriestley). · Explain WhyAug 31 2015, 11:01 PM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

application/

PhabricatorOwnersApplication.php

2 lines

docs/

user/

userguide/

owners.diviner

80 lines

Diff 33908

View Options

src/applications/owners/application/PhabricatorOwnersApplication.php