Page MenuHomePhabricator
Differential D14022

Fix an issue where paths could bleed across repos in Owners
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:49 PM
Unknown Object (File)
Sat, Nov 23, 12:59 PM
Unknown Object (File)
Sat, Nov 23, 12:59 PM
Unknown Object (File)
Sat, Nov 23, 12:59 PM
Unknown Object (File)
Wed, Nov 20, 11:39 AM
Unknown Object (File)
Wed, Nov 20, 11:39 AM
Unknown Object (File)
Wed, Nov 20, 11:39 AM
Unknown Object (File)
Nov 19 2024, 6:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8320: Bring Owners out of the dark ages
Commits
Restricted Diffusion Commit
rP809c7fb4f35e: Fix an issue where paths could bleed across repos in Owners
Summary

Ref T8320. I missed this a while ago and then it came to me in a dream.

Only consider paths in the same repo when looking at ownership.

(I think this is rarely reachable in practice.)

Test Plan

Verified that files and commits still listed ownership properly.

Diff Detail

Repository
rP Phabricator
Branch
ownerrepo
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7864
Build 8759: [Placeholder Plan] Wait for 30 Seconds
Build 8758: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33907.Aug 31 2015, 10:34 PM
epriestley retitled this revision from to Fix an issue where paths coudl bleed across repos in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8320: Bring Owners out of the dark ages.
epriestley retitled this revision from Fix an issue where paths coudl bleed across repos in Owners to Fix an issue where paths could bleed across repos in Owners.Aug 31 2015, 10:52 PM
chad accepted this revision.Sep 1 2015, 1:58 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 1 2015, 1:58 AM
Closed by commit rP809c7fb4f35e: Fix an issue where paths could bleed across repos in Owners (authored by epriestley, committed by epriestley). · Explain WhySep 1 2015, 3:07 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
query/
5 lines

Diff 33907

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
Phabricator · Built by Phacility