Paths

Table of Contentst

Differential D14021

Don't copy `null` attributes passed to JX.$N()
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 10:30 PM.

Details

Reviewers

chad

Maniphest Tasks

T8919: owners autocomplete send to /null url

Commits

Restricted Diffusion Commit
rPfe66d52a22a5: Don't copy `null` attributes passed to JX.$N()

Summary

Fixes T8919. In Safari, node.href = null; has no effect, but in Chrome it is like node.href = "null";.

Instead, just use semantics similar to phutil_tag(): don't assign attributes with null values.

Test Plan

No more /null href in Chrome in Owners typehaead.

Typeahead still works in Chrome/Safari.

Diff Detail

Repository

rP Phabricator

Branch

copynull

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7863
Build 8757: [Placeholder Plan] Wait for 30 Seconds
Build 8756: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33906.Aug 31 2015, 10:30 PM

epriestley retitled this revision from to Don't copy `null` attributes passed to JX.$N().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8919: owners autocomplete send to /null url.

chad accepted this revision.Aug 31 2015, 10:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 10:31 PM

Closed by commit rPfe66d52a22a5: Don't copy `null` attributes passed to JX.$N() (authored by epriestley, committed by epriestley). · Explain WhyAug 31 2015, 10:52 PM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

externals/

javelin/

lib/

DOM.js

8 lines

Diff 33906

View Options

webroot/rsrc/externals/javelin/lib/DOM.js

Don't copy `null` attributes passed to JX.$N()ClosedPublicActions