Differential D14012

Show "Login to Answer" in Ponder if viewer is logged out
ClosedPublic
Actions

Authored by chad on Aug 30 2015, 4:29 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9278: Viewing Ponder Question while not logged in has presentation inconsistent with Maniphest Tasks.

Commits

Restricted Diffusion Commit
rP506168c3073c: Show "Login to Answer" in Ponder if viewer is logged out

Summary

Fixes T9278. Logged out viewers shouldn't see a form field to answer, just a login button.

Test Plan

Log out, go to question, click Login to Answer, login, get redirected back.

Diff Detail

Repository

rP Phabricator

Branch

T9278

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7847
Build 8725: [Placeholder Plan] Wait for 30 Seconds
Build 8724: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33878.Aug 30 2015, 4:29 PM

chad added a task: T9278: Viewing Ponder Question while not logged in has presentation inconsistent with Maniphest Tasks..

chad retitled this revision from to Show "Login to Answer" in Ponder if viewer is logged out.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 30 2015, 4:29 PM

epriestley accepted this revision.Aug 31 2015, 10:57 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 10:57 AM

Closed by commit rP506168c3073c: Show "Login to Answer" in Ponder if viewer is logged out (authored by chad, committed by chad). · Explain WhyAug 31 2015, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

view/

PonderAddAnswerView.php

12 lines

Diff 33878

View Options

src/applications/ponder/view/PonderAddAnswerView.php

Show "Login to Answer" in Ponder if viewer is logged outClosedPublicActions