Page MenuHomePhabricator

Use 'remote.origin.url' fallback for git < 1.7.5
ClosedPublic

Authored by jbeta on Aug 26 2015, 10:01 PM.
Tags
None
Referenced Files
F15407137: D13998.id33824.diff
Tue, Mar 18, 3:59 PM
F15401731: D13998.diff
Mon, Mar 17, 7:02 PM
F15387309: D13998.diff
Sat, Mar 15, 2:11 AM
F15377444: D13998.id33823.diff
Thu, Mar 13, 8:53 AM
F15353037: D13998.id33823.diff
Mon, Mar 10, 7:46 PM
F15304860: D13998.id33823.diff
Thu, Mar 6, 2:17 AM
Unknown Object (File)
Thu, Feb 20, 5:00 PM
Unknown Object (File)
Thu, Feb 20, 8:45 AM
Subscribers

Details

Summary

'git ls-remote --get-url' is more correct, but younger and less
supported. This commit tempers previous optimism about its availability,
improving support for users of older git packages.

Test Plan
  • Set git config url.xttps.insteadOf https rewrite rule.
  • Ran arc which with git 1.7.5 in $PATH, saw rewritten configured remote.
  • Ran arc which with git 1.7.4 in $PATH, saw configured remote.

Diff Detail

Repository
rARC Arcanist
Branch
contain-your-enthusiasm
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7818
Build 8668: [Placeholder Plan] Wait for 30 Seconds
Build 8667: arc lint + arc unit