Ref T2015. This updates the blueprint / resource references in the Drydock view controllers to render as handles.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T2015: Implement Drydock
- Commits
- Restricted Diffusion Commit
rP0a3714507208: [drydock/core] Show blueprints / resources as links in Drydock view controllers
Viewed the controllers, saw links.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hachque-reconstructed
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7773 Build 8578: [Placeholder Plan] Wait for 30 Seconds Build 8577: arc lint + arc unit
Event Timeline
| src/applications/drydock/controller/DrydockLeaseViewController.php | ||
|---|---|---|
| 132 | Just use $viewer->renderHandle() in modern code. | |
| 133–137 | This branch is unreachable: HandleQuery never returns null. | |
| 141 | This will render "Unknown Resource" for a lease with no resource, which I believe is possible and which seems wrong? | |
| src/applications/drydock/controller/DrydockResourceViewController.php | ||
| 115–116 | Just use $viewer->renderHandle($resource->getBlueprintPHID()). | |