Paths

Table of Contentst

Differential D10873

[drydock/core] Show blueprints / resources as links in Drydock view controllers
ClosedPublic
Actions

Authored by hach-que on Nov 19 2014, 3:32 AM.

Tags

None

Referenced Files

	F15469716: D10873.diff
	Fri, Apr 4, 3:52 PM

	F15428986: D10873.diff
	Sun, Mar 23, 11:55 PM

	F15380810: D10873.id33757.diff
	Fri, Mar 14, 4:34 AM

	F15344056: D10873.id34180.diff
	Mon, Mar 10, 2:35 AM

	F15344055: D10873.id33768.diff
	Mon, Mar 10, 2:35 AM

	F15344053: D10873.id33757.diff
	Mon, Mar 10, 2:34 AM

	F15344052: D10873.id26112.diff
	Mon, Mar 10, 2:34 AM

	F15344049: D10873.id.diff
	Mon, Mar 10, 2:34 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Commits

Restricted Diffusion Commit
rP0a3714507208: [drydock/core] Show blueprints / resources as links in Drydock view controllers

Summary

Ref T2015. This updates the blueprint / resource references in the Drydock view controllers to render as handles.

Test Plan

Viewed the controllers, saw links.

Diff Detail

Repository

Branch

arcpatch-D10873

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7765
Build 8562: [Placeholder Plan] Wait for 30 Seconds
Build 8561: arc lint + arc unit

Event Timeline

hach-que updated this revision to Diff 26112.Nov 19 2014, 3:32 AM

hach-que retitled this revision from to Show blueprints / resources as links in Drydock view controllers.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2014, 3:32 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B3089: Diff 26112.Nov 19 2014, 3:32 AM

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:32 AM

devurandom added a subscriber: devurandom.Mar 2 2015, 8:38 PM

epriestley requested changes to this revision.Aug 8 2015, 6:34 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/drydock/controller/DrydockLeaseViewController.php
132	Just use `$viewer->renderHandle()` in modern code.
133–137	This branch is unreachable: HandleQuery never returns null.
141	This will render "Unknown Resource" for a lease with no resource, which I believe is possible and which seems wrong?
src/applications/drydock/controller/DrydockResourceViewController.php
115–116	Just use `$viewer->renderHandle($resource->getBlueprintPHID())`.

This revision now requires changes to proceed.Aug 8 2015, 6:34 PM

Made requested changes

Rebase

hach-que retitled this revision from Show blueprints / resources as links in Drydock view controllers to [drydock/core] Show blueprints / resources as links in Drydock view controllers.Aug 24 2015, 12:22 PM

I think I got one of these but let me see what else merges cleanly.

This revision is now accepted and ready to land.Sep 23 2015, 5:51 PM

Closed by commit rP0a3714507208: [drydock/core] Show blueprints / resources as links in Drydock view controllers (authored by epriestley, committed by epriestley). · Explain WhySep 23 2015, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

controller/

DrydockLeaseViewController.php

17 lines

DrydockResourceViewController.php

3 lines

phid/

DrydockBlueprintPHIDType.php

4 lines

DrydockResourcePHIDType.php

4 lines

Diff 33757

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

Loading...

src/applications/drydock/phid/DrydockResourcePHIDType.php

Loading...