Improve handling of PHP 5.4 features
Needs RevisionPublic
Actions

Authored by joshuaspence on Aug 23 2015, 1:55 AM.

Tags

None

Referenced Files

	F15469548: D13967.diff
	Fri, Apr 4, 2:29 PM

	F15446408: D13967.id.diff
	Thu, Mar 27, 6:57 PM

	F15424983: D13967.diff
	Sun, Mar 23, 1:34 AM

	F15413456: D13967.id.diff
	Wed, Mar 19, 6:51 PM

	F15393224: D13967.id.diff
	Sat, Mar 15, 8:29 PM

	F15390962: D13967.id33704.diff
	Sat, Mar 15, 7:31 AM

	F15334307: D13967.diff
	Mar 8 2025, 8:10 AM

	Unknown Object (File)
	Feb 20 2025, 2:00 AM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Summary

Ref T4334.

Test Plan

WIP

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7725
Build 8484: [Placeholder Plan] Wait for 30 Seconds
Build 8482: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33704.Aug 23 2015, 1:55 AM

joshuaspence retitled this revision from to Improve handling of PHP 5.4 features.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a task: T4334: Support PHP5.4+ syntax in XHPAST.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 1:55 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Fine when it passes, but I'd expect the line numbers will change. (This also didn't run its own test, per T9258.)

This revision now requires changes to proceed.Aug 27 2015, 11:24 AM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

php54-features.lint-test

6 lines

Diff 33704

View Options

src/lint/linter/tests/xhpast/php54-features.lint-test

Improve handling of PHP 5.4 featuresNeeds RevisionPublicActions