Differential D13962

Add XHPAST test for nested quotes
ClosedPublic
Actions

Authored by joshuaspence on Aug 22 2015, 2:42 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1941: Populating Symbol indexes fail

Commits

rPHU7ad7f2e43b3f: Add XHPAST test for nested quotes

Summary

Ref T1941. This result is wrong, but cover it with a test before I muck around with the parser itself (see D8029 for example).

Test Plan

Ran unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7720
Build 8475: [Placeholder Plan] Wait for 30 Seconds
Build 8474: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33696.Aug 22 2015, 2:42 AM

joshuaspence retitled this revision from to Add XHPAST test for nested quotes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T1941: Populating Symbol indexes fail.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 22 2015, 2:42 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 27 2015, 11:25 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 27 2015, 11:25 AM

Closed by commit rPHU7ad7f2e43b3f: Add XHPAST test for nested quotes (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 27 2015, 12:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-nested-quotes.test

4 lines

Diff 33696

View Options

src/parser/xhpast/tests/data/php-nested-quotes.test

Add XHPAST test for nested quotesClosedPublicActions