Paths

Table of Contentst

Differential D13960

Use semantic versioning for XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Aug 22 2015, 1:25 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUe276f31b7117: Use semantic versioning for XHPAST

Summary

Currently XHPAST is versioned as x.y.z/w which seems a little odd. Instead, use x.y.z as the version number to make it possible to use version_compare.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7717
Build 8468: [Placeholder Plan] Wait for 30 Seconds
Build 8467: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33693.Aug 22 2015, 1:25 AM

joshuaspence retitled this revision from to Use semantic versioning for XHPAST.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 22 2015, 1:25 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 22 2015, 10:54 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 22 2015, 10:54 AM

Closed by commit rPHUe276f31b7117: Use semantic versioning for XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 22 2015, 11:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

parser/

xhpast/

bin/

PhutilXHPASTBinary.php

2 lines

20%

support/

xhpast/

xhpast.cpp

2 lines

Diff 33693

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php