Page MenuHomePhabricator
Differential D13943

Add a call to `assert_instances_of`
ClosedPublic
Actions

Authored by joshuaspence on Aug 19 2015, 10:20 PM.
Tags
None
Referenced Files
F13817841: D13943.diff
Fri, Sep 20, 3:33 AM
Unknown Object (File)
Thu, Sep 12, 7:59 AM
Unknown Object (File)
Thu, Sep 5, 3:47 PM
Unknown Object (File)
Sat, Aug 31, 2:26 PM
Unknown Object (File)
Sat, Aug 31, 2:26 PM
Unknown Object (File)
Sat, Aug 31, 2:26 PM
Unknown Object (File)
Sat, Aug 31, 2:26 PM
Unknown Object (File)
Wed, Aug 28, 10:28 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe56f326cf72e: Add a call to `assert_instances_of`
Summary

This was taken from D13569.

Test Plan

arc lint still works.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7691
Build 8419: [Placeholder Plan] Wait for 30 Seconds
Build 8418: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33652.Aug 19 2015, 10:20 PM
joshuaspence retitled this revision from to Add a call to `assert_instances_of`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 19 2015, 10:20 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 20 2015, 11:51 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2015, 11:51 AM
Closed by commit rARCe56f326cf72e: Add a call to `assert_instances_of` (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 20 2015, 12:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
lint/
engine/
2 lines0%
Loading...

Diff 33652

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
Phabricator · Built by Phacility