Paths

Table of Contentst

Improve the "inline HTML" linter rule
ClosedPublic
Actions

Authored by joshuaspence on Aug 14 2015, 4:43 AM.

Tags

None

Referenced Files

	F15436935: D13896.id33544.diff
	Tue, Mar 25, 4:48 PM

	F15435600: D13896.id.diff
	Tue, Mar 25, 9:09 AM

	F15428604: D13896.id33544.diff
	Sun, Mar 23, 9:17 PM

	F15419798: D13896.id33544.diff
	Fri, Mar 21, 8:59 AM

	F15400042: D13896.id33544.diff
	Mon, Mar 17, 9:19 AM

	F15382418: D13896.diff
	Fri, Mar 14, 12:18 PM

	F15369567: D13896.id33544.diff
	Wed, Mar 12, 7:09 AM

	F15333813: D13896.id33544.diff
	Sat, Mar 8, 5:03 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC4404e66735c4: Improve the "inline HTML" linter rule

Summary

Improve ArcanistInlineHTMLXHPASTLinterRule such that it doesn't raise duplicate warnings. Also be a bit more lax with whitespace.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33544.Aug 14 2015, 4:43 AM

joshuaspence retitled this revision from to Improve the "inline HTML" linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 14 2015, 4:43 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 14 2015, 10:58 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 14 2015, 10:58 AM

Closed by commit rARC4404e66735c4: Improve the "inline HTML" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 19 2015, 5:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistInlineHTMLXHPASTLinterRule.php

5 lines

__tests__/

xhpast/

embedded-tags.lint-test

1 line

php-tags-bad.lint-test

1 line

Diff 33639

View Options

src/lint/linter/ArcanistInlineHTMLXHPASTLinterRule.php

View Options

src/lint/linter/tests/xhpast/embedded-tags.lint-test

View Options

src/lint/linter/tests/xhpast/php-tags-bad.lint-test

Improve the "inline HTML" linter ruleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33639

src/lint/linter/ArcanistInlineHTMLXHPASTLinterRule.php

src/lint/linter/__tests__/xhpast/embedded-tags.lint-test

src/lint/linter/__tests__/xhpast/php-tags-bad.lint-test

Improve the "inline HTML" linter rule
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/xhpast/embedded-tags.lint-test

src/lint/linter/tests/xhpast/php-tags-bad.lint-test