Differential D13928

Probably fix bad loadArtifactLease() call
ClosedPublic
Actions

Authored by epriestley on Aug 18 2015, 5:42 PM.

Details

Reviewers

chad

Maniphest Tasks

T9205: Bad loadArtifactLease parameters in Harbormaster

Commits

Restricted Diffusion Commit
rPb21270d498d3: Probably fix bad loadArtifactLease() call

Summary

Ref T9205. This is a likely fix.

Test Plan

This isn't straightforward to test in the upstream unless you have custom code on top of it.

Diff Detail

Repository

rP Phabricator

Branch

harbor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7666
Build 8370: [Placeholder Plan] Wait for 30 Seconds
Build 8369: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33616.Aug 18 2015, 5:42 PM

epriestley retitled this revision from to Probably fix bad loadArtifactLease() call.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9205: Bad loadArtifactLease parameters in Harbormaster.

chad accepted this revision.Aug 18 2015, 5:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 18 2015, 5:43 PM

Closed by commit rPb21270d498d3: Probably fix bad loadArtifactLease() call (authored by epriestley, committed by epriestley). · Explain WhyAug 18 2015, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterCommandBuildStepImplementation.php

3 lines

Diff 33616

View Options

src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php

Probably fix bad loadArtifactLease() callClosedPublicActions