Page MenuHomePhabricator

Further modernize OwnersPackageQuery
ClosedPublic

Authored by epriestley on Aug 17 2015, 4:14 PM.
Tags
None
Referenced Files
F15576702: D13922.id.diff
Tue, May 6, 10:16 AM
F15567118: D13922.diff
Fri, May 2, 4:28 AM
F15563113: D13922.id33602.diff
Wed, Apr 30, 6:22 AM
F15557780: D13922.id33598.diff
Mon, Apr 28, 11:11 PM
F15556193: D13922.id33598.diff
Mon, Apr 28, 3:07 PM
F15506397: D13922.diff
Tue, Apr 15, 10:54 AM
F15493087: D13922.id33598.diff
Sat, Apr 12, 9:25 PM
F15479243: D13922.id33602.diff
Tue, Apr 8, 5:36 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8320: Bring Owners out of the dark ages
Commits
Restricted Diffusion Commit
rP6cfeb9e54014: Further modernize OwnersPackageQuery
Summary

Ref T8320.

  • Add needOwners().
  • Split withOwnerPHIDs() [exact owners] and withAuthorityPHIDs() [indirect authority] apart.
  • Restore searching by path.
Test Plan

Browsed pacakges, edited packages, edited paths.

Diff Detail

Repository
rP Phabricator
Branch
owner2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7659
Build 8356: [Placeholder Plan] Wait for 30 Seconds
Build 8355: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Further modernize OwnersPackageQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.