Page MenuHomePhabricator

Fix Owners lookups for the repository root
ClosedPublic

Authored by epriestley on Aug 17 2015, 12:57 AM.
Tags
None
Referenced Files
F14043624: D13919.diff
Tue, Nov 12, 11:43 AM
F14031245: D13919.id33594.diff
Sat, Nov 9, 9:52 AM
F14031244: D13919.id33592.diff
Sat, Nov 9, 9:52 AM
F14031243: D13919.id.diff
Sat, Nov 9, 9:52 AM
F14027094: D13919.diff
Fri, Nov 8, 5:07 AM
F14022609: D13919.diff
Wed, Nov 6, 6:24 PM
F14019234: D13919.diff
Tue, Nov 5, 9:46 PM
F14006880: D13919.id33592.diff
Mon, Oct 28, 7:57 PM
Subscribers
None

Details

Summary

Ref T9201. At the root of a repository the current path is null, but the OwnersQuery wants strings.

This could be resolved a couple different ways, but just cast the arguments to strings since that seems reasonable enough.

Test Plan

Browsed root of a repository.

Diff Detail

Repository
rP Phabricator
Branch
toc2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7656
Build 8350: [Placeholder Plan] Wait for 30 Seconds
Build 8349: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix Owners lookups for the repository root.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2015, 12:58 AM
This revision was automatically updated to reflect the committed changes.