Page MenuHomePhabricator
Differential D13905

Add ability to reply to Ponder Answer emails
ClosedPublic
Actions

Authored by chad on Aug 15 2015, 1:27 AM.
Tags
None
Referenced Files
F13173613: D13905.diff
Tue, May 7, 8:20 PM
Unknown Object (File)
Sat, May 4, 7:27 PM
Unknown Object (File)
Wed, May 1, 2:01 PM
Unknown Object (File)
Wed, May 1, 1:02 AM
Unknown Object (File)
Sun, Apr 21, 7:21 PM
Unknown Object (File)
Thu, Apr 18, 10:51 AM
Unknown Object (File)
Thu, Apr 18, 2:54 AM
Unknown Object (File)
Thu, Apr 18, 2:54 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3846: Build reply handler functionality for Ponder
T9068: Answers don't publish to feed/mail
Commits
Restricted Diffusion Commit
rPee8e4363900e: Add ability to reply to Ponder Answer emails
Summary

Ref T9068, Ref T3846. Maybe fixes both, but I'm having issues testing email replies in a sandbox. Moves answer feed/mail generation to the AnswerEditor, hides it in QuestionEditor.

Test Plan

Write an answer, see feed story, check /mail/ for mail generation.

Diff Detail

Repository
rP Phabricator
Branch
ponder-answer-mail-2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7641
Build 8320: [Placeholder Plan] Wait for 30 Seconds
Build 8319: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33562.Aug 15 2015, 1:27 AM
chad retitled this revision from to Add ability to reply to Ponder Answer emails.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added tasks: T9068: Answers don't publish to feed/mail, T3846: Build reply handler functionality for Ponder.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 15 2015, 1:27 AM
chad updated this revision to Diff 33563.Aug 15 2015, 1:40 AM
  • remove custom feed handler
epriestley accepted this revision.Aug 17 2015, 4:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2015, 4:54 PM
Closed by commit rPee8e4363900e: Add ability to reply to Ponder Answer emails (authored by chad, committed by chad). · Explain WhyAug 17 2015, 5:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33563

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/ponder/editor/PonderQuestionEditor.php

Loading...
View Options

src/applications/ponder/feed/PonderTransactionFeedStory.php

Loading...
View Options

src/applications/ponder/mail/PonderAnswerMailReceiver.php

Loading...
View Options

src/applications/ponder/mail/PonderAnswerReplyHandler.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestionTransaction.php

Loading...
Phabricator · Built by Phacility