Simplify Countdown mailtags
ClosedPublic
Actions

Authored by chad on Aug 13 2015, 8:12 PM.

Tags

None

Referenced Files

	F13218567: D13888.id33525.diff
	Sat, May 18, 12:48 PM

	F13218566: D13888.diff
	Sat, May 18, 12:47 PM

	F13196133: D13888.diff
	Sun, May 12, 10:59 PM

	F13178645: D13888.diff
	Wed, May 8, 8:33 PM

	Unknown Object (File)
	Thu, Apr 25, 3:06 AM

	Unknown Object (File)
	Apr 17 2024, 3:41 PM

	Unknown Object (File)
	Apr 12 2024, 7:19 PM

	Unknown Object (File)
	Apr 12 2024, 7:19 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPf5ea5ba9fe7b: Simplify Countdown mailtags

Summary

These were a little silly, simplify them

Test Plan

New countdown, edit preferences, etc.

Diff Detail

Repository

rP Phabricator

Branch

countdown-mailtag

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7616
Build 8272: [Placeholder Plan] Wait for 30 Seconds
Build 8271: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33525.Aug 13 2015, 8:12 PM

chad retitled this revision from to Simplify Countdown mailtags.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 13 2015, 8:12 PM

epriestley accepted this revision.Aug 17 2015, 4:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 4:53 PM

Closed by commit rPf5ea5ba9fe7b: Simplify Countdown mailtags (authored by chad, committed by chad). · Explain WhyAug 17 2015, 5:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

countdown/

editor/

PhabricatorCountdownEditor.php

10 lines

storage/

PhabricatorCountdownTransaction.php

14 lines

Diff 33525

View Options

src/applications/countdown/editor/PhabricatorCountdownEditor.php