Simplify Countdown mailtags
ClosedPublic
Actions

Authored by chad on Aug 13 2015, 8:12 PM.

Tags

None

Referenced Files

	F15564143: D13888.id33601.diff
	Wed, Apr 30, 10:58 AM

	F15545969: D13888.id33525.diff
	Sat, Apr 26, 1:29 PM

	F15545968: D13888.diff
	Sat, Apr 26, 1:29 PM

	F15538039: D13888.id33601.diff
	Thu, Apr 24, 5:12 PM

	F15530316: D13888.id33525.diff
	Wed, Apr 23, 3:21 AM

	F15530315: D13888.diff
	Wed, Apr 23, 3:21 AM

	F15529949: D13888.id.diff
	Tue, Apr 22, 11:44 PM

	F15528071: D13888.id33601.diff
	Tue, Apr 22, 8:45 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPf5ea5ba9fe7b: Simplify Countdown mailtags

Summary

These were a little silly, simplify them

Test Plan

New countdown, edit preferences, etc.

Diff Detail

Repository

rP Phabricator

Branch

countdown-mailtag

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7616
Build 8272: [Placeholder Plan] Wait for 30 Seconds
Build 8271: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33525.Aug 13 2015, 8:12 PM

chad retitled this revision from to Simplify Countdown mailtags.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 13 2015, 8:12 PM

epriestley accepted this revision.Aug 17 2015, 4:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 4:53 PM

Closed by commit rPf5ea5ba9fe7b: Simplify Countdown mailtags (authored by chad, committed by chad). · Explain WhyAug 17 2015, 5:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

countdown/

editor/

PhabricatorCountdownEditor.php

10 lines

storage/

PhabricatorCountdownTransaction.php

14 lines

Diff 33525

View Options

src/applications/countdown/editor/PhabricatorCountdownEditor.php