Page MenuHomePhabricator
Differential D13882

Add a linter rule for global variables
ClosedPublic
Actions

Authored by joshuaspence on Aug 13 2015, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 6:33 PM
Unknown Object (File)
Fri, Jan 24, 8:04 AM
Unknown Object (File)
Fri, Jan 24, 8:04 AM
Unknown Object (File)
Fri, Jan 24, 8:04 AM
Unknown Object (File)
Fri, Jan 24, 8:04 AM
Unknown Object (File)
Tue, Jan 21, 3:30 PM
Unknown Object (File)
Tue, Jan 21, 12:49 PM
Unknown Object (File)
Fri, Jan 17, 3:31 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCbf88f4616cdf: Add a linter rule for global variables
Summary

Ref T7409. Global variables are gross and should be avoided like the plague.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7610
Build 8260: [Placeholder Plan] Wait for 30 Seconds
Build 8259: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33518.Aug 13 2015, 11:18 AM
joshuaspence retitled this revision from to Add a linter rule for global variables.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 13 2015, 11:18 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 13 2015, 2:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2015, 2:38 PM
Closed by commit rARCbf88f4616cdf: Add a linter rule for global variables (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
lint/
linter/
__tests__/
xhpast/
8 lines--
1 line--
2 lines--
xhpast/
rules/
28 lines100%
Loading...

Diff 33518

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/global-variables.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistGlobalVariableXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility