Page MenuHomePhabricator
Differential D13876

Micro-optimization for linting performance
ClosedPublic
Actions

Authored by joshuaspence on Aug 12 2015, 5:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 10:46 PM
Unknown Object (File)
Fri, Jan 24, 8:03 AM
Unknown Object (File)
Fri, Jan 24, 8:03 AM
Unknown Object (File)
Fri, Jan 24, 8:03 AM
Unknown Object (File)
Fri, Jan 24, 8:03 AM
Unknown Object (File)
Thu, Jan 23, 8:18 PM
Unknown Object (File)
Fri, Jan 17, 7:43 AM
Unknown Object (File)
Tue, Jan 14, 2:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUc76b692447af: Micro-optimization for linting performance
Summary

This is a micro-optimization to improve the performance of the XHPAST linter.

Test Plan

Ran arc lint --everything --never-apply-patches --xprofile=profile.json in rP. Compared the XHProf profile before and after.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7602
Build 8244: [Placeholder Plan] Wait for 30 Seconds
Build 8243: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33505.Aug 12 2015, 5:05 AM
joshuaspence retitled this revision from to Micro-optimization for linting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 12 2015, 5:05 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a comment.Aug 12 2015, 9:15 AM

I'm not entirely convinced that this is a good idea, but thought I'd pose the question.

Personally, it feels like assert_instances_of is something that should almost be a no-op when not running in development mode.

joshuaspence retitled this revision from Micro-optimization for linting to Micro-optimization for linting performance.Aug 12 2015, 9:16 AM
joshuaspence edited edge metadata.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Aug 12 2015, 1:47 PM
epriestley edited edge metadata.

I think this is fine to remove any time it shows up on a profile. I've made similar changes once or twice elsewhere.

In the general case I still want it to run in production, because it makes debugging easier.

My only thought is that maybe we should leave a comment when we remove it so it doesn't get confused for an oversight later.

This revision is now accepted and ready to land.Aug 12 2015, 1:47 PM
Closed by commit rPHUc76b692447af: Micro-optimization for linting performance (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 12 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
parser/
aast/
api/
2 lines0%
Loading...

Diff 33505

View Options

src/parser/aast/api/AASTNodeList.php

Loading...
Phabricator · Built by Phacility