Page MenuHomePhabricator
Differential D13869

Remove leftover code for "postponed" lint and unit status
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 1:42 PM.
Tags
None
Referenced Files
F14362286: D13869.diff
Fri, Dec 20, 12:36 PM
Unknown Object (File)
Thu, Dec 12, 6:36 AM
Unknown Object (File)
Thu, Dec 12, 4:22 AM
Unknown Object (File)
Sun, Dec 1, 11:19 AM
Unknown Object (File)
Thu, Nov 28, 3:45 PM
Unknown Object (File)
Wed, Nov 20, 11:40 PM
Unknown Object (File)
Nov 19 2024, 10:06 AM
Unknown Object (File)
Nov 16 2024, 2:07 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9134: Upgrading: Support for "Postponed" Lint and Unit Removed
Commits
Restricted Diffusion Commit
rPff6ccd5f68ac: Remove leftover code for "postponed" lint and unit status
Summary

Ref T9134. It looks like this functionality was removed in D13848.

Test Plan

Submitted a diff successfully.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7595
Build 8230: [Placeholder Plan] Wait for 30 Seconds
Build 8229: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33496.Aug 11 2015, 1:42 PM
joshuaspence retitled this revision from to Remove leftover code for "postponed" lint and unit status.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 1:42 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 2:06 PM
epriestley edited edge metadata.

See notes on D13868 for impact/timing, but I'm fine landing this stuff whenever.

This revision is now accepted and ready to land.Aug 11 2015, 2:06 PM
epriestley mentioned this in T9134: Upgrading: Support for "Postponed" Lint and Unit Removed.Aug 11 2015, 2:08 PM
joshuaspence updated this object.Aug 29 2015, 8:51 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
joshuaspence added a task: T9134: Upgrading: Support for "Postponed" Lint and Unit Removed.
Closed by commit rPff6ccd5f68ac: Remove leftover code for "postponed" lint and unit status (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 29 2015, 12:19 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a child revision: D13868: Remove leftover code for "postponed" lint and unit status.Aug 29 2015, 12:20 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
applications/
differential/
conduit/
7 lines26%
Loading...
constants/
1 line100%
Loading...
1 line100%
Loading...
1 line100%
Loading...
customfield/
4 lines0%
Loading...
4 lines0%
Loading...
view/
6 lines0%
Loading...
harbormaster/
view/
1 line3%
Loading...

Diff 33496

View Options

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

Loading...
View Options

src/applications/differential/constants/DifferentialLintStatus.php

Loading...
View Options

src/applications/differential/constants/DifferentialUnitStatus.php

Loading...
View Options

src/applications/differential/constants/DifferentialUnitTestResult.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitPropertyView.php

Loading...
Phabricator · Built by Phacility