Page MenuHomePhabricator
Differential D13862

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 12:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:07 PM
Unknown Object (File)
Tue, Dec 17, 9:07 PM
Unknown Object (File)
Tue, Dec 17, 8:07 PM
Unknown Object (File)
Tue, Dec 17, 7:12 PM
Unknown Object (File)
Fri, Dec 13, 1:00 AM
Unknown Object (File)
Thu, Dec 12, 3:40 PM
Unknown Object (File)
Mon, Dec 9, 9:54 PM
Unknown Object (File)
Mon, Dec 2, 5:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU6c0118085afd: Various linter fixes
Summary

Self explanatory.

Test Plan

arc lint

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorresources/test/diverse_symbols.php:17XHP45PHP Compatibility
Errorresources/test/diverse_symbols.php:23XHP3Use of Variable Variable
Unit
Tests Skipped
Build Status
Buildable 7586
Build 8212: [Placeholder Plan] Wait for 30 Seconds
Build 8211: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33478.Aug 11 2015, 12:14 PM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 12:14 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 12:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM
Closed by commit rPHU6c0118085afd: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
test/
2 lines
src/
future/
exec/
__tests__/
2 lines
lexer/
20 lines
markup/
engine/
remarkup/
blockrule/
2 lines
2 lines
parser/
argument/
__tests__/
20 lines
utils/
__tests__/
40 lines

Diff 33478

View Options

resources/test/diverse_symbols.php

Loading...
View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
View Options

src/lexer/PhutilPHPFragmentLexer.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php

Loading...
View Options

src/parser/argument/__tests__/PhutilArgumentParserTestCase.php

Loading...
View Options

src/utils/__tests__/PhutilUTF8TestCase.php

Loading...
Phabricator · Built by Phacility