Page MenuHomePhabricator
Differential D13857

Add a linter rule for the use of `parse_str`
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 2:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 4:48 AM
Unknown Object (File)
Thu, Jan 30, 4:48 AM
Unknown Object (File)
Wed, Jan 29, 8:03 PM
Unknown Object (File)
Wed, Jan 29, 8:02 PM
Unknown Object (File)
Wed, Jan 29, 7:34 PM
Unknown Object (File)
Wed, Jan 29, 1:35 AM
Unknown Object (File)
Tue, Jan 28, 7:49 AM
Unknown Object (File)
Sun, Jan 26, 2:35 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str`
Summary

The use of the parse_str method (when called without sepcifying a second parameter) hinders static analysis. Specifically, the parse_str('...') behaves similarly to extract.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7580
Build 8200: [Placeholder Plan] Wait for 30 Seconds
Build 8199: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
6,276 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
424 msArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
2,229 msArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
730 msArcanistChmodLinterTestCase::Unknown Unit Message ("")
116 msArcanistClosureLinterTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33470.Aug 11 2015, 2:00 AM
joshuaspence retitled this revision from to Add a linter rule for the use of `parse_str`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 2:00 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 2:56 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 2:56 AM
Closed by commit rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str` (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
lint/
linter/
__tests__/
xhpast/
5 lines--
7 lines--
xhpast/
rules/
29 lines100%
Loading...

Diff 33470

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/extract-use.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/parse_str-use.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistParseStrUseXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility