Paths

Table of Contentst

Differential D13857

Add a linter rule for the use of `parse_str`
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 2:00 AM.

Tags

None

Referenced Files

	F15384939: D13857.diff
	Fri, Mar 14, 9:14 PM

	Unknown Object (File)
	Mon, Mar 3, 10:46 PM

	Unknown Object (File)
	Fri, Feb 28, 10:00 PM

	Unknown Object (File)
	Feb 8 2025, 9:55 PM

	Unknown Object (File)
	Feb 8 2025, 9:55 PM

	Unknown Object (File)
	Feb 8 2025, 9:55 PM

	Unknown Object (File)
	Feb 8 2025, 9:55 PM

	Unknown Object (File)
	Feb 2 2025, 3:55 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str`

Summary

The use of the parse_str method (when called without sepcifying a second parameter) hinders static analysis. Specifically, the parse_str('...') behaves similarly to extract.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7580
Build 8200: [Placeholder Plan] Wait for 30 Seconds
Build 8199: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	6,276 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	424 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	2,229 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	730 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	116 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33470.Aug 11 2015, 2:00 AM

joshuaspence retitled this revision from to Add a linter rule for the use of `parse_str`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 2:00 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 11 2015, 2:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2015, 2:56 AM

Closed by commit rARCfe8ed2a6f8b0: Add a linter rule for the use of `parse_str` (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 13 2015, 9:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

lint/

linter/

__tests__/

xhpast/

extract-use.lint-test

5 lines

-

-

parse_str-use.lint-test

7 lines

-

-

xhpast/

rules/

ArcanistParseStrUseXHPASTLinterRule.php

29 lines

100%

Loading...

Diff 33470

src/__phutil_library_map__.php

Loading...

src/lint/linter/tests/xhpast/extract-use.lint-test

Loading...

src/lint/linter/tests/xhpast/parse_str-use.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistParseStrUseXHPASTLinterRule.php

Loading...