Page MenuHomePhabricator

Add a linter rule for array elements
ClosedPublic

Authored by joshuaspence on Aug 10 2015, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 4:09 PM
Unknown Object (File)
Wed, Feb 26, 8:26 AM
Unknown Object (File)
Tue, Feb 25, 3:46 AM
Unknown Object (File)
Feb 16 2025, 10:38 PM
Unknown Object (File)
Feb 11 2025, 8:12 PM
Unknown Object (File)
Feb 11 2025, 6:27 PM
Unknown Object (File)
Feb 11 2025, 5:30 PM
Unknown Object (File)
Feb 11 2025, 5:27 PM
Subscribers

Details

Summary

Add a linter rule to ensure that array elements occupy a single line each.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7574
Build 8188: [Placeholder Plan] Wait for 30 Seconds
Build 8187: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for array elements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistArrayElementXHPASTLinterRule.php
38 ↗(On Diff #33423)

Maybe check $value->getLineNumber()? Or look at all the nonsemantic tokens? I think this raises a false positive on:

array(
  /* OPEN   */ 1,
  /* CLOSED */ 2,
);

...which is nonstandard in this codebase, but seems reasonable.

This revision is now accepted and ready to land.Aug 10 2015, 1:40 PM
This revision was automatically updated to reflect the committed changes.