Page MenuHomePhabricator
Differential D13805

Add a linter rule for unary postfix expression spacing
ClosedPublic
Actions

Authored by joshuaspence on Aug 6 2015, 12:40 AM.
Tags
None
Referenced Files
F15478815: D13805.id33345.diff
Tue, Apr 8, 3:00 AM
F15477264: D13805.diff
Mon, Apr 7, 1:10 PM
F15460703: D13805.id33343.diff
Tue, Apr 1, 1:23 AM
F15460499: D13805.id.diff
Mon, Mar 31, 11:19 PM
F15450632: D13805.id.diff
Fri, Mar 28, 4:48 PM
F15450631: D13805.id33345.diff
Fri, Mar 28, 4:48 PM
F15450629: D13805.id33343.diff
Fri, Mar 28, 4:48 PM
F15450628: D13805.id33344.diff
Fri, Mar 28, 4:48 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC968f4ae5d73e: Add a linter rule for unary postfix expression spacing
Summary

Unary postfix expressions should not have a space before the operator.

Test Plan

Added test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7505
Build 8050: [Placeholder Plan] Wait for 30 Seconds
Build 8049: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33343.Aug 6 2015, 12:40 AM
joshuaspence retitled this revision from to Add a linter rule for unary postfix expression spacing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 6 2015, 12:40 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 6 2015, 12:42 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistUnaryPostfixExpressionSpacingXHPASTLinterRule.php
30

Looks like this is actually testing "preceded", not "followed"?

This revision is now accepted and ready to land.Aug 6 2015, 12:42 AM
joshuaspence updated this revision to Diff 33344.Aug 6 2015, 1:47 AM
joshuaspence edited edge metadata.

Fix linter message

joshuaspence marked an inline comment as done.Aug 6 2015, 1:49 AM
Closed by commit rARC968f4ae5d73e: Add a linter rule for unary postfix expression spacing (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 6 2015, 1:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
lint/
linter/
__tests__/
xhpast/
9 lines--
xhpast/
rules/
36 lines100%
Loading...
5 lines100%
Loading...

Diff 33344

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/unary-postfix-expression-spacing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnaryPostfixExpressionSpacingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility