Page MenuHomePhabricator
Differential D13797

Add a linter rule for unary prefix expression spacing
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 12:17 PM.
Tags
None
Referenced Files
F13920969: D13797.id33339.diff
Thu, Oct 10, 9:23 PM
F13920967: D13797.id33338.diff
Thu, Oct 10, 9:23 PM
F13920949: D13797.id33319.diff
Thu, Oct 10, 9:20 PM
F13920659: D13797.diff
Thu, Oct 10, 7:25 PM
Unknown Object (File)
Mon, Sep 30, 8:06 PM
Unknown Object (File)
Thu, Sep 26, 5:40 PM
Unknown Object (File)
Thu, Sep 26, 5:26 PM
Unknown Object (File)
Sun, Sep 22, 12:08 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCc8f0deffab60: Add a linter rule for unary prefix expression spacing
Summary

Add a linter rule to ensure that there is no space between the operator and the operand in a unary prefix expression.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33319.Aug 5 2015, 12:17 PM
joshuaspence retitled this revision from to Add a linter rule for unary prefix expression spacing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 12:17 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 5 2015, 3:55 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRule.php
28

Maybe the more colloquial "followed" instead of technically-correct-but-unusual-in-common-use "succeeded"?

This revision is now accepted and ready to land.Aug 5 2015, 3:55 PM
joshuaspence updated this revision to Diff 33338.Aug 5 2015, 9:14 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.
  • Tweak linter message
  • Ignore print, echo and clone
Closed by commit rARCc8f0deffab60: Add a linter rule for unary prefix expression spacing (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 5 2015, 9:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33339

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/exit-expression.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unary-prefix-expression-spacing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility