Ref T3578 Allows display of projects if available on individual ponder search results.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3578: Unbeta Ponder
- Commits
- Restricted Diffusion Commit
rPfdc1662bfd91: Add Projects to Ponder Search View
Added projects to my questions, see them display on search results.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ponder-tags
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7494 Build 8028: [Placeholder Plan] Wait for 30 Seconds Build 8027: arc lint + arc unit
Event Timeline
| src/applications/ponder/query/PonderQuestionQuery.php | ||
|---|---|---|
| 57 | Consider needProjectPHIDs for clarity (loading PHIDs vs Project objects)? | |
| src/applications/ponder/query/PonderQuestionSearchEngine.php | ||
| 69–70 | Is there any particular reason for this change? It seems a little inconsistent to make the default include closed/archived questions (defaults generally exclude closed/archived objects in other applications, I think). | |
| src/applications/ponder/storage/PonderQuestion.php | ||
| 36 | Consider projectPHIDs instead of edgeProjectPHIDs for consistency? | |
| src/applications/ponder/query/PonderQuestionSearchEngine.php | ||
|---|---|---|
| 69–70 | This is probably "exploratory". I'm trying to get a better sense of real use of the product. In this what I'm thinking is "all" questions are generally interesting, even if they've been resolved. There are two types of Ponder users, the browsers "I just want to learn" and the helpers "I want to provide answers". I think "closed" states should expand - "Resolved, Duplicate, Invalid" and an "archive" state should maybe be added. You could outright archive questions that were no longer valid (like an older product version). Let me back out this change for now and give it some thought. | |
Comment Actions
Yeah, I think "Closed" and "Answered" are maybe not the same. For example, I could imagine a sequence of events like this:
- User A asks a good question about system X.
- User B provides a good answer.
- Someone marks the question as "Has Good Answer" or something.
- A couple of years later, we stop using X, so the question is now misleading, even though it was a good question at the time.
- Someone closes the question as "Obsolete" -- but it still has a good answer. Seems like it should be "Has Good Answer, Obsolete", not just "Obsolete"?
Comment Actions
So ... split out a separate archive or just have lots of different closed states to build queries from?
Comment Actions
Yeah, I imagine probably replacing the single "Archived" state with a selection of closed states ("Obsolete", "Duplicate", "Invalid", ...) but having all of them mean "This question isn't good for answering or learning from."