Page MenuHomePhabricator
Differential D13798

Add a linter rule for object operator spacing
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 1:43 PM
Unknown Object (File)
Tue, Dec 24, 2:03 AM
Unknown Object (File)
Mon, Dec 23, 7:35 PM
Unknown Object (File)
Thu, Dec 19, 4:09 PM
Unknown Object (File)
Dec 8 2024, 11:32 PM
Unknown Object (File)
Dec 6 2024, 6:55 AM
Unknown Object (File)
Nov 27 2024, 9:34 PM
Unknown Object (File)
Nov 18 2024, 9:41 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC986f5d82d073: Add a linter rule for object operator spacing
Summary

Add a linter rule to check that there is no whitespace surrounding the object operator, ->.

Test Plan

Added test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7493
Build 8026: [Placeholder Plan] Wait for 30 Seconds
Build 8025: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33320.Aug 5 2015, 12:33 PM
joshuaspence retitled this revision from to Add a linter rule for object operator spacing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 12:33 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 5 2015, 3:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2015, 3:56 PM
Closed by commit rARC986f5d82d073: Add a linter rule for object operator spacing (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 5 2015, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
lint/
linter/
__tests__/
xhpast/
12 lines--
xhpast/
rules/
47 lines100%
Loading...

Diff 33320

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/object-operating-spacing.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistObjectOperatorSpacingXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility