Page MenuHomePhabricator
Differential D13693

Fix some failing unit tests
ClosedPublic
Actions

Authored by joshuaspence on Jul 23 2015, 9:01 AM.
Tags
None
Referenced Files
F13920978: D13693.id33271.diff
Thu, Oct 10, 9:26 PM
F13920954: D13693.id33093.diff
Thu, Oct 10, 9:21 PM
F13920660: D13693.diff
Thu, Oct 10, 7:25 PM
Unknown Object (File)
Tue, Oct 1, 4:15 PM
Unknown Object (File)
Fri, Sep 27, 11:34 AM
Unknown Object (File)
Sun, Sep 22, 6:04 PM
Unknown Object (File)
Sun, Sep 15, 8:46 AM
Unknown Object (File)
Sep 7 2024, 7:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC0d6f3328a08f: Fix some failing unit tests
Summary

I somehow missed these.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33093.Jul 23 2015, 9:01 AM
joshuaspence retitled this revision from to Fix some failing unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 23 2015, 9:01 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 23 2015, 12:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2015, 12:28 PM
Closed by commit rARC0d6f3328a08f: Fix some failing unit tests (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 2 2015, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
xhpast/
2 lines
2 lines
2 lines

Diff 33271

View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

Loading...
Phabricator · Built by Phacility