Page MenuHomePhabricator
Differential D13773

Partially update Maniphest for handleProcess
ClosedPublic
Actions

Authored by chad on Aug 1 2015, 4:49 PM.
Tags
None
Referenced Files
F14057094: D13773.diff
Sun, Nov 17, 12:23 AM
F14043774: D13773.diff
Tue, Nov 12, 12:48 PM
F14039984: D13773.id33265.diff
Mon, Nov 11, 7:00 AM
F14039351: D13773.id33251.diff
Mon, Nov 11, 5:18 AM
F14039350: D13773.diff
Mon, Nov 11, 5:18 AM
F14023492: D13773.id33251.diff
Thu, Nov 7, 2:27 AM
F14023490: D13773.diff
Thu, Nov 7, 2:21 AM
F14014688: D13773.id33266.diff
Sun, Nov 3, 6:43 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP3b0ca7b76995: Partially update Maniphest for handleProcess
Summary

Starts conversion of Maniphest to handleProcess, chopping up to reduce errors.

Test Plan

New Task, Edit Task, Change Priority, Move on workboard, view reports, batch edit tasks

Diff Detail

Repository
rP Phabricator
Branch
maniphest-process
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7464
Build 7968: [Placeholder Plan] Wait for 30 Seconds
Build 7967: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33251.Aug 1 2015, 4:49 PM
chad retitled this revision from to Partially update Maniphest for handleProcess.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2015, 4:49 PM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Aug 1 2015, 5:02 PM
epriestley accepted this revision.Aug 1 2015, 10:34 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/maniphest/controller/ManiphestBatchEditController.php
6

$this->getViewer() is preferred.

src/applications/maniphest/controller/ManiphestExportController.php
17–18

Or $dialog = $this->newDialog(); to automatically set the user.

This revision is now accepted and ready to land.Aug 1 2015, 10:34 PM
chad updated this revision to Diff 33265.Aug 2 2015, 12:03 AM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • full update
Closed by commit rP3b0ca7b76995: Partially update Maniphest for handleProcess (authored by chad, committed by chad). · Explain WhyAug 2 2015, 12:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33251

View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestExportController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestSubpriorityController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskListController.php

Loading...
Phabricator · Built by Phacility