Differential D13772

Update Help for handleRequest
ClosedPublic
Actions

Authored by chad on Aug 1 2015, 4:09 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

Restricted Diffusion Commit
rPdeb06727eaf2: Update Help for handleRequest

Summary

Updates Help for handleRequest

Test Plan

Launch help dialog, close dialog

Diff Detail

Repository

rP Phabricator

Branch

help-process

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7463
Build 7966: [Placeholder Plan] Wait for 30 Seconds
Build 7965: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33250.Aug 1 2015, 4:09 PM

chad retitled this revision from to Update Help for processRequest.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2015, 4:09 PM

chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Aug 1 2015, 5:02 PM

chad retitled this revision from Update Help for processRequest to Update Help for handleRequest.Aug 1 2015, 7:31 PM

chad updated this object.

epriestley accepted this revision.Aug 1 2015, 10:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2015, 10:38 PM

Closed by commit rPdeb06727eaf2: Update Help for handleRequest (authored by chad, committed by chad). · Explain WhyAug 1 2015, 10:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

help/

controller/

PhabricatorHelpEditorProtocolController.php

5 lines

PhabricatorHelpKeyboardShortcutController.php

7 lines

Diff 33250

View Options

src/applications/help/controller/PhabricatorHelpEditorProtocolController.php