Page MenuHomePhabricator
Differential D13753

Uninstalling an application, as a non-admin, should give the same modal as clicking "Edit Policies"
ClosedPublic
Actions

Authored by lpriestley on Jul 29 2015, 3:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 7:03 AM
Unknown Object (File)
Wed, Dec 4, 11:09 PM
Unknown Object (File)
Sat, Nov 30, 4:51 AM
Unknown Object (File)
Fri, Nov 29, 2:51 PM
Unknown Object (File)
Fri, Nov 29, 2:51 PM
Unknown Object (File)
Fri, Nov 29, 2:48 PM
Unknown Object (File)
Fri, Nov 29, 2:34 PM
Unknown Object (File)
Fri, Nov 29, 4:54 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8893: Provide user-friendly modal when a non-administrator attempts to uninstall an application
Commits
Restricted Diffusion Commit
rPb24935df2f74: Uninstalling an application, as a non-admin, should give the same modal as…
Summary

Fixes T8893, Uninstalling an application, as a non-admin, should give the same modal as clicking "Edit Policies".

Test Plan

Open /applications/view/PhabricatorAuditApplication/ and confirm that "Edit Policies" and "Uninstall" result in the same modal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 33217.Jul 29 2015, 3:08 AM
lpriestley retitled this revision from to Uninstalling an application, as a non-admin, should give the same modal as clicking "Edit Policies".
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8893: Provide user-friendly modal when a non-administrator attempts to uninstall an application.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 29 2015, 3:08 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 29 2015, 3:12 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 29 2015, 3:12 AM
Closed by commit rPb24935df2f74: Uninstalling an application, as a non-admin, should give the same modal as… (authored by lpriestley, committed by lpriestley). · Explain WhyJul 29 2015, 3:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
meta/
controller/
14 lines

Diff 33218

View Options

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

Loading...
Phabricator · Built by Phacility