Page MenuHomePhabricator
Differential D13753

Uninstalling an application, as a non-admin, should give the same modal as clicking "Edit Policies"
ClosedPublic
Actions

Authored by lpriestley on Jul 29 2015, 3:08 AM.
Tags
None
Referenced Files
F14052850: D13753.diff
Fri, Nov 15, 11:11 AM
F14043948: D13753.diff
Tue, Nov 12, 2:12 PM
F14038908: D13753.diff
Mon, Nov 11, 2:42 AM
F14024924: D13753.diff
Thu, Nov 7, 1:21 PM
F13990445: D13753.id33218.diff
Tue, Oct 22, 3:40 AM
F13973882: D13753.diff
Oct 18 2024, 3:08 AM
F13971809: D13753.id.diff
Oct 17 2024, 3:26 PM
F13971795: D13753.id33217.diff
Oct 17 2024, 3:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8893: Provide user-friendly modal when a non-administrator attempts to uninstall an application
Commits
Restricted Diffusion Commit
rPb24935df2f74: Uninstalling an application, as a non-admin, should give the same modal as…
Summary

Fixes T8893, Uninstalling an application, as a non-admin, should give the same modal as clicking "Edit Policies".

Test Plan

Open /applications/view/PhabricatorAuditApplication/ and confirm that "Edit Policies" and "Uninstall" result in the same modal.

Diff Detail

Repository
rP Phabricator
Branch
uninstallapplication
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7439
Build 7918: [Placeholder Plan] Wait for 30 Seconds
Build 7917: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 33217.Jul 29 2015, 3:08 AM
lpriestley retitled this revision from to Uninstalling an application, as a non-admin, should give the same modal as clicking "Edit Policies".
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8893: Provide user-friendly modal when a non-administrator attempts to uninstall an application.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 29 2015, 3:08 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 29 2015, 3:12 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 29 2015, 3:12 AM
Closed by commit rPb24935df2f74: Uninstalling an application, as a non-admin, should give the same modal as… (authored by lpriestley, committed by lpriestley). · Explain WhyJul 29 2015, 3:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
meta/
controller/
14 lines

Diff 33217

View Options

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

Loading...
Phabricator · Built by Phacility