Fix public/private profile edit note
ClosedPublic
Actions

Authored by chad on Jul 27 2015, 10:04 PM.

Details

Reviewers

Maniphest Tasks

T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false

Commits

Restricted Diffusion Commit
rP535c1a5f255e: (stable) Fix public/private profile edit note
rP84049e6d075b: Fix public/private profile edit note

Summary

Fixes T8976. Checks state of note before applying to box.

Test Plan

Set policy to login, edit profile.

Diff Detail

Repository

rP Phabricator

Branch

profile-public

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7422
Build 7884: [Placeholder Plan] Wait for 30 Seconds
Build 7883: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33188.Jul 27 2015, 10:04 PM

chad retitled this revision from to Fix public/private profile edit note.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 27 2015, 10:04 PM

epriestley accepted this revision.Jul 27 2015, 10:05 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2015, 10:05 PM

sorry, mis-saved

Closed by commit rP84049e6d075b: Fix public/private profile edit note (authored by chad, committed by chad). · Explain WhyJul 27 2015, 10:12 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given.Jul 29 2015, 1:24 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileEditController.php

2 lines

Diff 33188

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Fix public/private profile edit noteClosedPublicActions