Paths

Table of Contentst

Put the HeraldActionRecord table back on the shelf
ClosedPublic
Actions

Authored by epriestley on Jul 27 2015, 2:54 PM.

Details

Reviewers

Maniphest Tasks

T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist)

Commits

Restricted Diffusion Commit
rP04c40e3abf10: (stable) Put the HeraldActionRecord table back on the shelf
rP8d53f1511565: Put the HeraldActionRecord table back on the shelf

Summary

Fixes T8958. I renamed this class and table (in D13644), but the migration 20150606.mlist.1.php needs to load records from the table before the table rename applies.

Put the table back and accept a tiny bit of cruft here to fix this problem. We can no-op the migration after a while.

I'll cherry-pick this to stable.

Test Plan

Applied migration. Created Herald rules. Reviewed existing Herald rules.

Diff Detail

Repository

rP Phabricator

Branch

haction

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/herald/storage/HeraldActionRecord.php:11	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 7418
Build 7876: [Placeholder Plan] Wait for 30 Seconds
Build 7875: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33174.Jul 27 2015, 2:54 PM

epriestley retitled this revision from to Put the HeraldActionRecord table back on the shelf.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist).

Herald added a subscriber: epriestley. · View Herald TranscriptJul 27 2015, 2:54 PM

Closed by commit rP8d53f1511565: Put the HeraldActionRecord table back on the shelf (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2015, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150727.heraldaction.1.sql

2 lines

src/

applications/

herald/

storage/

HeraldActionRecord.php

8 lines

Diff 33174

View Options

resources/sql/autopatches/20150727.heraldaction.1.sql