Page MenuHomePhabricator
Differential D13724

Convert Macro to handleRequest
ClosedPublic
Actions

Authored by chad on Jul 26 2015, 8:04 PM.
Tags
None
Referenced Files
F19031450: D13724.diff
Nov 25 2025, 1:10 AM
F18882406: D13724.id.diff
Nov 6 2025, 10:59 PM
F18874263: D13724.diff
Nov 5 2025, 1:51 PM
F18835584: D13724.diff
Oct 26 2025, 5:05 PM
F18820265: D13724.id33155.diff
Oct 22 2025, 1:41 PM
F18763327: D13724.id.diff
Oct 6 2025, 11:48 PM
F18761342: D13724.id33178.diff
Oct 6 2025, 1:48 PM
F18756846: D13724.diff
Oct 5 2025, 1:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP18a9fe85c835: Convert Macro to handleRequest
Summary

Converts Macro app

Test Plan

Make Macro, Make meme

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7406
Build 7852: [Placeholder Plan] Wait for 30 Seconds
Build 7851: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33155.Jul 26 2015, 8:04 PM
chad retitled this revision from to Convert Macro to handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 26 2015, 8:04 PM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Jul 26 2015, 9:07 PM
epriestley accepted this revision.Jul 27 2015, 2:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2015, 2:36 PM
Closed by commit rP18a9fe85c835: Convert Macro to handleRequest (authored by chad, committed by chad). · Explain WhyJul 27 2015, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33155

View Options

src/applications/macro/controller/PhabricatorMacroAudioController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroCommentController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroDisableController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroEditController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroListController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroMemeController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroMemeDialogController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
Phabricator · Built by Phacility