Correct rendering of "Another Herald Rule" conditions in Herald
ClosedPublic
Actions

Authored by epriestley on Jul 23 2015, 8:28 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8920: 'Another Herald rule matches' is being displayed as a raw PHID

Commits

Restricted Diffusion Commit
rP65bef30eb81a: Correct rendering of "Another Herald Rule" conditions in Herald

Summary

Fixes T8920. These are semi-magical and need to be slightly special cased, now.

Test Plan

Screen Shot 2015-07-23 at 1.27.17 PM.png (1×1 px, 158 KB)

Diff Detail

Repository

rP Phabricator

Branch

heraldview

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7372
Build 7784: [Placeholder Plan] Wait for 30 Seconds
Build 7783: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33104.Jul 23 2015, 8:28 PM

epriestley retitled this revision from to Correct rendering of "Another Herald Rule" conditions in Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T8920: 'Another Herald rule matches' is being displayed as a raw PHID.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 23 2015, 8:28 PM

btrahan accepted this revision.Jul 24 2015, 5:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jul 24 2015, 5:40 PM

Closed by commit rP65bef30eb81a: Correct rendering of "Another Herald Rule" conditions in Herald (authored by epriestley, committed by epriestley). · Explain WhyJul 24 2015, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

field/

HeraldAnotherRuleField.php

10 lines

Diff 33104

View Options

src/applications/herald/field/HeraldAnotherRuleField.php

Correct rendering of "Another Herald Rule" conditions in HeraldClosedPublicActions