Page MenuHomePhabricator

Correct rendering of "Another Herald Rule" conditions in Herald
ClosedPublic

Authored by epriestley on Jul 23 2015, 8:28 PM.

Details

Summary

Fixes T8920. These are semi-magical and need to be slightly special cased, now.

Test Plan

Diff Detail

Repository
rP Phabricator
Branch
heraldview
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 7372
Build 7784: [Placeholder Plan] Wait for 30 Seconds
Build 7783: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33104.Jul 23 2015, 8:28 PM
epriestley retitled this revision from to Correct rendering of "Another Herald Rule" conditions in Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
btrahan accepted this revision.Jul 24 2015, 5:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:40 PM
This revision was automatically updated to reflect the committed changes.