Page MenuHomePhabricator
Differential D13693

Fix some failing unit tests
ClosedPublic
Actions

Authored by joshuaspence on Jul 23 2015, 9:01 AM.
Tags
None
Referenced Files
F15523431: D13693.diff
Mon, Apr 21, 1:23 AM
F15519514: D13693.id33271.diff
Sat, Apr 19, 11:36 PM
F15519513: D13693.id.diff
Sat, Apr 19, 11:36 PM
F15517122: D13693.id33093.diff
Sat, Apr 19, 12:39 AM
F15510638: D13693.id33271.diff
Wed, Apr 16, 8:28 PM
F15510637: D13693.id.diff
Wed, Apr 16, 8:28 PM
F15510636: D13693.diff
Wed, Apr 16, 8:28 PM
F15456731: D13693.diff
Sun, Mar 30, 11:44 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC0d6f3328a08f: Fix some failing unit tests
Summary

I somehow missed these.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7367
Build 7774: [Placeholder Plan] Wait for 30 Seconds
Build 7773: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33093.Jul 23 2015, 9:01 AM
joshuaspence retitled this revision from to Fix some failing unit tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 23 2015, 9:01 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 23 2015, 12:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2015, 12:28 PM
Closed by commit rARC0d6f3328a08f: Fix some failing unit tests (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 2 2015, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
__tests__/
xhpast/
2 lines
2 lines
2 lines

Diff 33093

View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/naming-conventions.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/undeclared-variables.lint-test

Loading...
Phabricator · Built by Phacility