Page MenuHomePhabricator
Differential D13662

Modularize config modules + add edges, phid modules
ClosedPublic
Actions

Authored by epriestley on Jul 21 2015, 12:04 AM.
Tags
None
Referenced Files
F18584472: D13662.diff
Thu, Sep 11, 12:41 PM
F18506256: D13662.id.diff
Fri, Sep 5, 1:17 AM
F18498773: D13662.diff
Thu, Sep 4, 7:02 PM
F17628892: D13662.diff
Jul 10 2025, 8:09 AM
Unknown Object (File)
Jun 18 2025, 8:57 AM
Unknown Object (File)
Jun 8 2025, 3:37 PM
Unknown Object (File)
Jun 8 2025, 3:37 PM
Unknown Object (File)
Jun 8 2025, 3:05 PM
View All Files
Subscribers
epriestley
Tokens
"Like" token, awarded by frankth1."Like" token, awarded by joshuaspence.

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6859: It is difficult to keep track of used PhabricatorEdgeType IDs
Commits
Restricted Diffusion Commit
rPffa4cae6276e: Modularize config modules + add edges, phid modules
Summary

Fixes T6859. Adds a readout in /config/ of installed edge and PHID types. See also D13626.

Test Plan

Screen Shot 2015-07-20 at 5.03.57 PM.png (1×1 px, 287 KB)

Diff Detail

Repository
rP Phabricator
Branch
edgephids
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7327
Build 7694: [Placeholder Plan] Wait for 30 Seconds
Build 7693: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33029.Jul 21 2015, 12:04 AM
epriestley retitled this revision from to Modularize config modules + add edges, phid modules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 21 2015, 12:04 AM
epriestley mentioned this in D13626: Badges v0.1.Jul 21 2015, 12:06 AM
chad accepted this revision.Jul 21 2015, 12:08 AM
chad edited edge metadata.
chad added inline comments.
src/applications/config/module/PhabricatorConfigEdgeModule.php
44

prefer setTable which applies additional classes.

src/applications/config/module/PhabricatorConfigPHIDModule.php
44

setTable

src/applications/config/module/PhabricatorConfigSiteModule.php
43

setTable

This revision is now accepted and ready to land.Jul 21 2015, 12:08 AM
Closed by commit rPffa4cae6276e: Modularize config modules + add edges, phid modules (authored by epriestley, committed by epriestley). · Explain WhyJul 21 2015, 12:08 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jul 21 2015, 12:10 AM

You have 3 Inlines not marked as done, proceed anyways? [y/N]

joshuaspence awarded a token.Jul 21 2015, 2:35 AM
• frankth1 awarded a token.Jul 21 2015, 5:02 PM
epriestley mentioned this in T9367: Add another accept state for code review.Sep 9 2015, 1:47 PM

Revision Contents
Changeset List

Diff 33029

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/application/PhabricatorConfigApplication.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigModuleController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigSiteModuleController.php

Loading...
View Options

src/applications/config/module/PhabricatorConfigEdgeModule.php

Loading...
View Options

src/applications/config/module/PhabricatorConfigModule.php

Loading...
View Options

src/applications/config/module/PhabricatorConfigPHIDModule.php

Loading...
View Options

src/applications/config/module/PhabricatorConfigSiteModule.php

Loading...
Phabricator · Built by Phacility