Center button icons when on mobile displays
ClosedPublic
Actions

Authored by chad on Jul 18 2015, 4:45 AM.

Details

Reviewers

joshuaspence
epriestley
btrahan

Maniphest Tasks

T8885: Application pin button is misaligned

Commits

Restricted Diffusion Commit
rPcee3cde8245d: Center button icons when on mobile displays

Summary

Fixes T8885. This view is restricted enough on mobile that we can widen and center the icon.

Test Plan

Test workboards, pinning apps, viewing action menus.

Diff Detail

Repository

rP Phabricator

Branch

button-action-center

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7303
Build 7646: [Placeholder Plan] Wait for 30 Seconds
Build 7645: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32994.Jul 18 2015, 4:45 AM

chad retitled this revision from to Center button icons when on mobile displays.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan, joshuaspence.

chad added a task: T8885: Application pin button is misaligned.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 18 2015, 4:45 AM

epriestley accepted this revision.Jul 18 2015, 7:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 18 2015, 7:17 PM

Closed by commit rPcee3cde8245d: Center button icons when on mobile displays (authored by chad, committed by chad). · Explain WhyJul 18 2015, 7:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

5 lines

Diff 32994

View Options

resources/celerity/map.php