Fix a phutil_json_decode call in CustomField PHID
ClosedPublic
Actions

Authored by chad on Jul 17 2015, 2:28 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause)
T8866: PhutilJSONParserException error when access phabricator/T2050 page.

Commits

Restricted Diffusion Commit
rP039be71b87a0: Fix a phutil_json_decode call in CustomField PHID

Summary

I assume this is correct, it fixes my test case and was inconsistent with the rest of the file.

Test Plan

Add and Remove a CustomFieldPHID in Maniphest, no longer get errors.

Diff Detail

Repository

rP Phabricator

Branch

json

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7296
Build 7631: [Placeholder Plan] Wait for 30 Seconds
Build 7630: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32983.Jul 17 2015, 2:28 AM

chad retitled this revision from to Fix a phutil_json_decode call in CustomField PHID.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 17 2015, 2:28 AM

chad added a task: T8866: PhutilJSONParserException error when access phabricator/T2050 page..Jul 17 2015, 2:28 AM

epriestley accepted this revision.Jul 17 2015, 4:00 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2015, 4:00 AM

Closed by commit rP039be71b87a0: Fix a phutil_json_decode call in CustomField PHID (authored by chad, committed by chad). · Explain WhyJul 17 2015, 4:02 AM

This revision was automatically updated to reflect the committed changes.

andypuettmann added a task: T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).Jul 17 2015, 9:56 AM

andypuettmann mentioned this in T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldPHIDs.php

2 lines

Diff 32983

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Fix a phutil_json_decode call in CustomField PHIDClosedPublicActions