Page MenuHomePhabricator

Fix some Releeph jankiness in interacting with the redesign
ClosedPublic

Authored by epriestley on Jul 8 2015, 3:03 PM.
Tags
None
Referenced Files
F14034791: D13604.id32877.diff
Sun, Nov 10, 2:10 AM
F14034722: D13604.id32876.diff
Sun, Nov 10, 1:54 AM
F14034461: D13604.id.diff
Sun, Nov 10, 12:24 AM
F14034233: D13604.id.diff
Sat, Nov 9, 11:05 PM
F14001248: D13604.id32876.diff
Fri, Oct 25, 5:34 AM
F13998685: D13604.diff
Thu, Oct 24, 10:41 AM
F13985846: D13604.id.diff
Oct 20 2024, 11:11 PM
Unknown Object (File)
Oct 11 2024, 3:09 PM
Subscribers

Details

Summary

Releeph does some really old sketchy stuff in result rendering. Modernize it, remove the holdover/oldschool interface (these were the last two implementors) and make errors a little softer.

Test Plan

Viewed Releeph products and branches.

Diff Detail

Repository
rP Phabricator
Branch
engine1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/releeph/query/ReleephRequestSearchEngine.php:183XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7216
Build 7474: [Placeholder Plan] Wait for 30 Seconds
Build 7473: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix some Releeph jankiness in interacting with the redesign.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 3:08 PM
This revision was automatically updated to reflect the committed changes.