Page MenuHomePhabricator
Differential D13604

Fix some Releeph jankiness in interacting with the redesign
ClosedPublic
Actions

Authored by epriestley on Jul 8 2015, 3:03 PM.
Tags
None
Referenced Files
F14373318: D13604.diff
Fri, Dec 20, 8:38 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sat, Dec 7, 11:27 AM
Unknown Object (File)
Sat, Dec 7, 3:56 AM
Unknown Object (File)
Thu, Dec 5, 12:44 PM
Unknown Object (File)
Wed, Dec 4, 12:28 AM
Unknown Object (File)
Tue, Dec 3, 1:11 PM
Unknown Object (File)
Tue, Dec 3, 1:11 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPae81f86a67b3: Fix some Releeph jankiness in interacting with the redesign
Summary

Releeph does some really old sketchy stuff in result rendering. Modernize it, remove the holdover/oldschool interface (these were the last two implementors) and make errors a little softer.

Test Plan

Viewed Releeph products and branches.

Diff Detail

Repository
rP Phabricator
Branch
engine1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/releeph/query/ReleephRequestSearchEngine.php:183XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 7216
Build 7474: [Placeholder Plan] Wait for 30 Seconds
Build 7473: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32876.Jul 8 2015, 3:03 PM
epriestley retitled this revision from to Fix some Releeph jankiness in interacting with the redesign.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 8 2015, 3:03 PM
chad accepted this revision.Jul 8 2015, 3:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 3:08 PM
Closed by commit rPae81f86a67b3: Fix some Releeph jankiness in interacting with the redesign (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2015, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32876

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchViewController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductViewController.php

Loading...
View Options

src/applications/releeph/query/ReleephBranchSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestSearchEngine.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/interface/PhabricatorApplicationSearchResultsControllerInterface.php

Loading...
Phabricator · Built by Phacility