Use PhutilClassMapQuery where appropriate.
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPf695dcea9ee8: Use PhutilClassMapQuery
Browsed around the UI to verify things seemed somewhat working.
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Errors Severity Location Code Message Error src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:21 PHL1 Unknown Symbol - Unit
Tests Passed - Build Status
Buildable 7174 Build 7393: [Placeholder Plan] Wait for 30 Seconds Build 7392: arc lint + arc unit
Event Timeline
- This is great.
- One actual functional bug inline, I think (HarbormasterBlueprint).
- Let's hold the rest of this until after I promote stuff to stable in about 48 hours, just because I'm worried there will be some weird thing with sorting or caching that's not very obvious but will break something, and this is hard to test exhaustively.
src/applications/base/PhabricatorApplication.php | ||
---|---|---|
392–393 | You could probably put the sorting in the Query here, too. | |
src/applications/celerity/resources/CelerityPhysicalResources.php | ||
22 | We could maybe simplify this one at some point by adding a getAndValidateName() (or getNameForClassMap()?) method that handles the validation inside the MapQuery: $name = $this->getName(); // validate here return $name; | |
src/applications/drydock/blueprint/DrydockBlueprintImplementation.php | ||
377 | I think getType is not guaranteed to be unique. It describes a resource type, but multiple blueprints can provide different ways to build the same sort of resource (for example, an "EC2" blueprint and a "WindowsAzure" blueprint could both build "host" resources). | |
src/applications/herald/adapter/HeraldAdapter.php | ||
1028 | This one is correct, I believe. | |
src/applications/policy/capability/PhabricatorPolicyCapability.php | ||
85 | I think these weren't sorted before, although I think sorting them is OK. |
Oh, there's also one more of these that only exists in the redesign-2015 branch (CelerityPostprocessor).