Page MenuHomePhabricator
Differential D13499

Modularize Application Email Herald field
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 11:28 PM.
Tags
None
Referenced Files
F14060984: D13499.diff
Mon, Nov 18, 4:32 AM
F14060181: D13499.id32782.diff
Sun, Nov 17, 11:41 PM
F14052474: D13499.id32782.diff
Fri, Nov 15, 9:06 AM
F14046495: D13499.diff
Wed, Nov 13, 9:32 PM
F14045005: D13499.id32782.diff
Tue, Nov 12, 11:55 PM
F14044023: D13499.id32782.diff
Tue, Nov 12, 2:41 PM
F14040003: D13499.id32782.diff
Mon, Nov 11, 7:03 AM
F14036331: D13499.diff
Sun, Nov 10, 9:44 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP9f220995b246: Modularize Application Email Herald field
Summary

Ref T8726. There's no interface we can check for this, so the adapter needs to opt in.

Also fix a spelling mistake.

Test Plan

Created rules with "Application Email" fields.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32654.Jun 30 2015, 11:28 PM
epriestley retitled this revision from to Modularize Application Email Herald field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 11:28 PM
btrahan accepted this revision.Jul 1 2015, 5:22 PM
btrahan edited edge metadata.
btrahan added inline comments.
resources/sql/autopatches/20150630.herald.1.sql
2–6

ugg, thanks

This revision is now accepted and ready to land.Jul 1 2015, 5:22 PM
Closed by commit rP9f220995b246: Modularize Application Email Herald field (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
5 lines
src/
2 lines
applications/
herald/
adapter/
28 lines
5 lines
metamta/
herald/
41 lines

Diff 32782

View Options

resources/sql/autopatches/20150630.herald.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/metamta/herald/PhabricatorMetaMTAApplicationEmailHeraldField.php

Loading...
Phabricator · Built by Phacility