Page MenuHomePhabricator
Differential D13515

[Redesgin] Misc Inline Comment tweaks
ClosedPublic
Actions

Authored by chad on Jul 1 2015, 5:19 PM.
Tags
None
Referenced Files
F14035362: D13515.id.diff
Sun, Nov 10, 5:37 AM
F14034704: D13515.id.diff
Sun, Nov 10, 1:50 AM
F13999292: D13515.diff
Thu, Oct 24, 2:00 PM
F13995776: D13515.id.diff
Wed, Oct 23, 3:25 PM
F13993363: D13515.id32677.diff
Tue, Oct 22, 10:24 PM
Unknown Object (File)
Oct 7 2024, 4:29 AM
Unknown Object (File)
Oct 6 2024, 7:30 PM
Unknown Object (File)
Oct 6 2024, 7:30 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP3b755115c2d8: [Redesgin] Misc Inline Comment tweaks
Summary

Ref T8099. Better alignment with TODO and Ghost Icons.

Test Plan

Test more states of inline comments, ghosts, todos, unsubmitted, etc.

Diff Detail

Repository
rP Phabricator
Branch
inline-comments
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7098
Build 7248: [Placeholder Plan] Wait for 30 Seconds
Build 7247: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32675.Jul 1 2015, 5:19 PM
chad retitled this revision from to [Redesgin] Misc Inline Comment tweaks.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 1 2015, 5:19 PM
epriestley accepted this revision.Jul 1 2015, 6:30 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 6:30 PM
Closed by commit rP3b755115c2d8: [Redesgin] Misc Inline Comment tweaks (authored by chad, committed by chad). · Explain WhyJul 1 2015, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
diff/
view/
28 lines
webroot/
rsrc/
css/
application/
differential/
15 lines

Diff 32675

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
Phabricator · Built by Phacility