Page MenuHomePhabricator
Differential D13514

Modularize all remaining Phriction Herald fields
ClosedPublic
Actions

Authored by epriestley on Jul 1 2015, 3:31 PM.
Tags
None
Referenced Files
F14061403: D13514.diff
Mon, Nov 18, 6:30 AM
F14047939: D13514.diff
Thu, Nov 14, 5:53 AM
F14034475: D13514.diff
Sun, Nov 10, 12:30 AM
F14018886: D13514.diff
Tue, Nov 5, 8:26 PM
F14008528: D13514.diff
Tue, Oct 29, 11:51 PM
Unknown Object (File)
Oct 11 2024, 2:55 PM
Unknown Object (File)
Oct 8 2024, 3:13 PM
Unknown Object (File)
Sep 27 2024, 10:10 PM
View All Files
Subscribers
eadler
epriestley
• GoogleLegacy

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP68de3dae9ab0: Modularize all remaining Phriction Herald fields
Summary

Ref T8726.

Test Plan
  • Created a rule using all the fields.
  • Updated documents, saw rule apply, reviewed transcript.
  • Migrated stuff.

Diff Detail

Repository
rP Phabricator
Branch
hmodular9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7097
Build 7246: [Placeholder Plan] Wait for 30 Seconds
Build 7245: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32674.Jul 1 2015, 3:31 PM
epriestley retitled this revision from to Modularize all remaining Phriction Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 1 2015, 3:31 PM
btrahan accepted this revision.Jul 1 2015, 5:30 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:30 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
Closed by commit rP68de3dae9ab0: Modularize all remaining Phriction Herald fields (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:17 PM
This revision was automatically updated to reflect the committed changes.
• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 9:07 AM
This comment was removed by epriestley.
• GoogleLegacy added a comment.Sep 10 2018, 9:08 AM
This comment was removed by epriestley.

Revision Contents
Changeset List

Diff 32674

View Options

resources/sql/autopatches/20150701.herald.2.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/pholio/herald/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentAuthorHeraldField.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentContentHeraldField.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldField.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentPathHeraldField.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentTitleHeraldField.php

Loading...
Phabricator · Built by Phacility